Kurosu a écrit :
> Kurosu a écrit :
>   
>> As the ml tends to strip even patches, you can find a mirror of the
>> patch here:
>> http://kurosu.free.fr/wormux/singleton.diff
>>     
>
> gentildemon, drayan? I'd really like your feedback before applying what
> I consider such a broadly-scoped patch.
>
> Best regards,
>   

Ok, I have just done a full review of your patch, and it seems pretty 
good for my point of view :-)

I have noticed that there is a strange line in your patch. In 
src/interface/cursor.h, there is

+  bool IsDisplayed() const;

I think it is not from the right patch :-)


In my mind, you can apply it, it's far better that what we have 
currently. (Anyway, I am thinking about atomicity with threads and how 
it can be handle)...

Regards,

Matt (gentildemon)

_______________________________________________
Wormux-dev mailing list
Wormux-dev@gna.org
https://mail.gna.org/listinfo/wormux-dev

Répondre à