On 27/10/2015 16:28, Richard Shaw wrote: Hi Richard, > Also, while you're at it I have some improvement ideas for the > superbuild script: > > https://dl.dropboxusercontent.com/u/34775202/wsjt/wsjtx-1.5-qt54.patch > > 1. The change from ${MAKE_EXECUTABLE} to $(MAKE) How does this work? I note that it does work but I do not understand who or where $(MAKE) is being defined? > > The probably obsoletes the need to find make, also, it passes the > current instance of make to the external project so SMP flags work (-jX) > > 2. I removed the LOG options from the external projects because it was > redirecting (not tee'ing) into a file which means the resultant > build.log from rpmbuild did not have the verbose build info and had to > be extracted from the internal cmake logs. > > Further, it separates the stdout and stderr which makes it impossible > to see the error inline for proper context. In my experience verbose logs are not necessary and the logs created by the CMake ExternalProject_Add() command are sufficient. I wonder if there is an issue with viewing these logs of stdout and stderr in the CMake build tree? > > 3. I had to add V=1 for hamlib to get verbose output during build > (automake equivalent to VERBOSE=1) to check build flags. OK. > > 4. I had to force -fPIC for the hamlib build. I assume this is a bug > in it's configure because both gcc and g++ are checked for PIC > compatibility but only the c++ files are compiled with -fPIC. I am still confused by this one, looking into it. > > Obviously you can ignore the patch line as that was my workaround for > the qt 5.4 issue. > > Thanks, > Richard 73 Bill G4WJS.
------------------------------------------------------------------------------ _______________________________________________ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel
