On Tue, Oct 27, 2015 at 1:25 PM, Bill Somerville <[email protected]> wrote:
> On 27/10/2015 16:28, Richard Shaw wrote: > > Hi Richard, > > Also, while you're at it I have some improvement ideas for the > > superbuild script: > > > > https://dl.dropboxusercontent.com/u/34775202/wsjt/wsjtx-1.5-qt54.patch > > > > 1. The change from ${MAKE_EXECUTABLE} to $(MAKE) > How does this work? I note that it does work but I do not understand who > or where $(MAKE) is being defined? > I think make defines it but I'm not 100% positive. I ran into this on another project I was setting up external projects for. > > 2. I removed the LOG options from the external projects because it was > > redirecting (not tee'ing) into a file which means the resultant > > build.log from rpmbuild did not have the verbose build info and had to > > be extracted from the internal cmake logs. > > > > Further, it separates the stdout and stderr which makes it impossible > > to see the error inline for proper context. > In my experience verbose logs are not necessary and the logs created by > the CMake ExternalProject_Add() command are sufficient. I wonder if > there is an issue with viewing these logs of stdout and stderr in the > CMake build tree? > Well, they're not needed when everything works :) Verbose log files are preferred for packaging purposes since things don't always go well, and with build systems I don't always have access to the cmake logs but all non-redirected output goes into build.log. Thanks, Richard
------------------------------------------------------------------------------
_______________________________________________ wsjt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wsjt-devel
