Great patch. Nice putting the shaded asm stuff in it's own module so
it could be simply referenced by the other modules. That's exactly
how I would have done it.
Any FYI that we can still leave the asm dep in xbean-reflect as
optional. There's magic code that loads AsmParameterNameLoader via
reflection so if asm isn't present everything can still work. In fact
we could possibly have two copies of that class, one for the shaded
version of asm and one for the non-shaded version of asm. Maybe
AsmParameterNameLoader and XbeanAsmParameterNameLoader? Maybe for
order we'd try to load the XbeanAsmParameterNameLoader version first
then try the non-shaded AsmParameterNameLoader version second.
-David
On May 22, 2009, at 3:11 PM, Jacek Laskowski wrote:
On Fri, May 22, 2009 at 11:37 PM, Jacek Laskowski
<[email protected]> wrote:
One (small) step at a time? :) I'll give it a shot ->
https://issues.apache.org/jira/browse/XBEAN-129
Done. It turned out very easy. Thanks for encouragement :)
Jacek
--
Jacek Laskowski
Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl
