On Tue, May 26, 2009 at 1:11 AM, David Blevins <[email protected]> wrote: > Great patch. Nice putting the shaded asm stuff in it's own module so it > could be simply referenced by the other modules. That's exactly how I would > have done it.
With all the hints around it wasn't really such an achievement :) > Any FYI that we can still leave the asm dep in xbean-reflect as optional. > There's magic code that loads AsmParameterNameLoader via reflection so if > asm isn't present everything can still work. In fact we could possibly have > two copies of that class, one for the shaded version of asm and one for the > non-shaded version of asm. Maybe AsmParameterNameLoader and > XbeanAsmParameterNameLoader? Maybe for order we'd try to load the > XbeanAsmParameterNameLoader version first then try the non-shaded > AsmParameterNameLoader version second. Noted. I don't know where you're heading yet, but will digest it in a couple of days and eventually get back with a patch. Jacek -- Jacek Laskowski Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl
