On Sat, Nov 6, 2010 at 7:01 AM, Adam Lee <[email protected]> wrote:
> Converted to Unix eols. Can someone please verify this has been completed?
>
> Cheers,
> Adam
>
>> Date: Fri, 5 Nov 2010 23:48:45 -0400
>> Subject: Re: [Xbmc-addons] [SVN Pull] skin.xperience
>> From: [email protected]
>> To: [email protected]
>> CC: [email protected]; [email protected]
>>
>> On Fri, Nov 5, 2010 at 10:39 PM, Adam Lee <[email protected]> wrote:
>> > Can you please further explain converting to Unix eols?
>> >
>> > Cheers.
>> >
>> >> Date: Fri, 5 Nov 2010 22:31:53 -0400
>> >> Subject: Re: [Xbmc-addons] [SVN Pull] skin.xperience
>> >> From: [email protected]
>> >> To: [email protected]
>> >> CC: [email protected]; [email protected]
>> >>
>> >> On Fri, Nov 5, 2010 at 5:38 PM, Adam Lee <[email protected]> wrote:
>> >> > All done! lol Well I hope anyways, can someone take a look and see
>> >> > please?
>> >> >
>> >> > What's been done:
>> >> >
>> >> > Edited xml per request
>> >> > gfx with 1x1 dimensions have been changed to 4x4.
>> >> >
>> >> >> Date: Fri, 5 Nov 2010 12:03:23 -0400
>> >> >> Subject: Re: [Xbmc-addons] [SVN Pull] skin.xperience
>> >> >> From: [email protected]
>> >> >> To: [email protected]
>> >> >> CC: [email protected]; [email protected]
>> >> >>
>> >> >> On Thu, Nov 4, 2010 at 7:10 PM, Adam Lee <[email protected]> wrote:
>> >> >> > Aside from the images you needed me to edit (just got new pc,
>> >> >> > doesn't
>> >> >> > like
>> >> >> > photoshop) Corey I have updated the svn. Edited the recentlyadded
>> >> >> > xml,
>> >> >> > and
>> >> >> > (Ihope) removed all the exec props. Please verify when you can.
>> >> >> >
>> >> >> > Cheers,
>> >> >> > Adam
>> >> >> >
>> >> >>
>> >> >> Adam
>> >> >>
>> >> >> Yep, svn props are fixed. Thanks for that.
>> >> >>
>> >> >> There's still the one xml error. My xml verifier doesn't like the
>> >> >> nested comment, so it wants a "-->" after the </control> on line 695
>> >> >> of skin.xperience/720p/Include_Categories-Recently-Added.xml.
>> >> >>
>> >> >> It's probably harmless, but I ask that all commits to our repo be
>> >> >> 100%
>> >> >> valid XML. This allows me to check new revisions for problems, and
>> >> >> has
>> >> >> already let me catch a few accidents.
>> >> >>
>> >> >> Please let me know when you've fixed up the images, then we'll move
>> >> >> on
>> >> >> to the line-endings. I think we're in the clear after that :)
>> >> >>
>> >> >> Cory
>> >> >
>> >>
>> >> Ok, looks good. Now if we can convert to Unix eols, that is the end of
>> >> my list of nits. Please see some of the other initial commit threads
>> >> like Night or Shade. Long story short, Notepad++ has the ability to
>> >> change. Not sure if it's good for changing many files at once. Maybe
>> >> someone else could offer some better win32 advice.
>> >>
>> >> So far, being a linux/git guy, I've had zero good advice for you.
>> >> Sorry for that :)
>> >>
>> >> Cory
>> >
>>
>> Sorry, I'm of little help for windows, best I can do is provide some
>> reading material: http://en.wikipedia.org/wiki/Newline
>>
>> We use Unix EOLs in the repo. Maybe some of the other skin devs can
>> shed some light on how they've converted?
>>
>> After a batch conversion, you can tell your skin editor to use Unix style.
>>
>> Cory
>

Yep, looks good.

Last issue remaining is the animations. They need to be moved outside
of /media in order to function correctly when xpr'd. You can ask some
of the other Blackbolt guys about this, I remember seeing some
discussion on the forum about it in the last few days.

Cory

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to