On 29/10/2015 23:50, ronie wrote: > On 28-10-15 22:34, Robert Hudson wrote: >> >> >> On 28/10/2015 20:02, ronie wrote: >>> On 26-10-15 08:04, Robert Hudson wrote: >>>> >>>> >>>> On 20/10/2015 16:37, ronie wrote: >>>>> On 20-10-15 07:29, Robert Hudson wrote: >>>>>> >>>>>> Please go ahead and pull this one in. >>>>>> >>>>>> I don't understand why you can't do a git roll-back of the change >>>>>> to remove Background media integration (For the next release at >>>>>> least). TvTunes will still play the themes without any skin >>>>>> changes (It didn't need skin changes to play the themes for >>>>>> several versions) - just the skin will look rubbish at that time. >>>>>> >>>>>> It is the "PlayingBackgroundMedia" support (Which I made generic >>>>>> to support any kind of background media) that will make the >>>>>> difference to users - the specific TvTunes button and >>>>>> configuration setting is not really required any more, so how >>>>>> about redoing that change. >>>>>> >>>>>> Rob >>>>>> >>>>> >>>>> updated, thx! >>>>> >>>>> i'll check with the other skinners on the team if we can bring >>>>> back the PlayingBackgroundMedia check in Confluence. >>>>> >>>>> >>>>> cheers, >>>>> ronie >>>> >>>> Hi Ronie, >>>> >>>> Any news on if PlayingBackgroundMedia check in Confluence will be >>>> restored? >>>> >>>> Thanks >>>> >>>> Rob >>>> >>> hey Rob, >>> >>> part of our skinning team is out of the country so i haven't had the >>> change to discus it with them. >>> the devs that commented on my question whether we should back the >>> check in Confluence, >>> were more in favour of adding some functionallity in Kodi that would >>> provide addons with >>> the abillity to play sounds in the background, so that it wouldn't >>> need skin support. >>> >>> >>> cheers, >>> ronie >> >> Hi Ronie, >> >> Thanks for the update. I don't deny some alternative method may be >> good, I recall something similar being discussed a couple of years >> ago, but then it didn't go anywhere. >> >> How about we add back in the PlayingBackgroundMedia flag until an >> alternative method is implemented? :) >> >> Thanks >> >> Rob > > hi Rob, > > would you be willing to create a PR for that? > i think that's the best way forward. > > cheers, > ronie
Hi ronie, Sorry for the delay, have now managed to create a pull request: https://github.com/xbmc/xbmc/pull/8363 Thanks Rob ------------------------------------------------------------------------------ _______________________________________________ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
