On 6/11/25 01:23, Jan Beulich wrote:
> On 10.06.2025 19:46, Stewart Hildebrand wrote:
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -258,6 +258,16 @@ config PARTIAL_EMULATION
>>
>> source "arch/arm/firmware/Kconfig"
>>
>> +config PCI_PASSTHROUGH
>> + bool "PCI passthrough" if EXPERT
>> + depends on ARM_64
>> + select HAS_PCI
>> + select HAS_VPCI
>> + select HAS_VPCI_GUEST_SUPPORT
>
> What about HAS_PASSTHROUGH? Seeing that being selected by MMU, what about
> that connection here?
Hm, yes. I'm not sure if depends or select would be better?
depends on ARM_64 && HAS_PASSTHROUGH
or
select HAS_PASSTHROUGH
> Selecting HAS_VPCI shouldn't really be necessary; HAS_VPCI_GUEST_SUPPORT
> does that for you already. (I further wonder whether HAS_VPCI wouldn't
> in turn better select HAS_PCI.)
I'd be happy to make these changes.
>> + default n
>
> This is unnecessary (redundant) and would hence better be omitted.
OK, I'll remove it.
