On 12.06.2025 15:39, Stewart Hildebrand wrote: > On 6/11/25 01:23, Jan Beulich wrote: >> On 10.06.2025 19:46, Stewart Hildebrand wrote: >>> --- a/xen/arch/arm/Kconfig >>> +++ b/xen/arch/arm/Kconfig >>> @@ -258,6 +258,16 @@ config PARTIAL_EMULATION >>> >>> source "arch/arm/firmware/Kconfig" >>> >>> +config PCI_PASSTHROUGH >>> + bool "PCI passthrough" if EXPERT >>> + depends on ARM_64 >>> + select HAS_PCI >>> + select HAS_VPCI >>> + select HAS_VPCI_GUEST_SUPPORT >> >> What about HAS_PASSTHROUGH? Seeing that being selected by MMU, what about >> that connection here? > > Hm, yes. I'm not sure if depends or select would be better? > > depends on ARM_64 && HAS_PASSTHROUGH > > or > > select HAS_PASSTHROUGH
Actually, thinking of it: HAS_* shouldn't be selected based on user choices, imo. Perhaps unless the HAS_* is a sub-feature of the dependent (as in e.g. "select HAS_VPCI if HVM" as we have it for x86). In which case all the select-s here might be wrong to use. Jan Jan
