Regards, Manish Jaggi
________________________________________ From: Julien Grall <julien.gr...@linaro.org> Sent: Friday, March 27, 2015 6:34 PM To: Jaggi, Manish; Xen Devel; prasun.kap...@cavium.com; Kumar, Vijaya; Ian Campbell; Stefano Stabellini Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain Hi manish, On 27/03/15 07:24, Manish Jaggi wrote: > It is good for code readability as there are many structures ending with > the name domain. > Also a code like this one is now easy to understand with the rename > old: dev_iommu_domain(dev) = domain; > new: dev_iommu_domain(dev) = iommu_domain; [manish] Did u see this line > > Also in current code struct smmu_domain pointer variable name is always > smmu_domain. > The change is on the same lines You are modifying the code from Linux just for your own comprehension. And we are trying to not diverge from a specific Linux commit in order to easily backport patch. [manish] please rethink on nack. There are so many data structures ending in _domain we need to provide proper naming. NAcked-by: Julien Grall <julien.gr...@linaro.org> Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
