On 8/5/19 4:58 PM, Jan Beulich wrote: > On 26.07.2019 08:25, Dario Faggioli wrote: >> vcpu_deassign() is called only once (in _vcpu_remove()). >> >> Let's consolidate the two functions into one. >> >> No functional change intended. >> >> Signed-off-by: Dario Faggioli <dfaggi...@suse.com> >> Acked-by: George Dunlap <george.dun...@citrix.com> > > I'm puzzled by commit a397471278, in two ways: > > 1) The commit is empty, presumably because I did apply the patch a few > days ago already. > > 2) The committer is recorded as "Patchew Importer <impor...@patchew.org>". > Do we really want to hide the fact who has been committing a patch? > While it's mostly mechanical, there's still the human decision of "this > is ready to go in" involved, which I don't think a bot can reliably take > in all cases.
Both of these are mistakes, and due to the fact that I `git fetch`ed patchew's commit rather than doing `git am` of the mbox provided by patchew. (And I used patchew's commit because somehow 4/4 didn't reach my inbox.) Re #1, I re-reviewed v2 from the commit itself; but then rebased before pushing, and didn't notice that the commit ended up being empty. Re #2, I guess that means I shouldn't really be pushing from patchew's commit anyway. Either way, sorry about the mistake; I'll try to remember to avoid using patchew's commit in the future. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
