> BTW, providing a patch, even if it's trivial, is always welcome in such
> cases.

I had already attached it to the email, but then i thought it was so
ridiculously small ... and removed it :)
So here it is again.

 
> Well, -Wall should be considered a reasonable policy to keep code clean.
> Me feeling is that this switch is fairly appropriate, specifically for
> real-time applications. But it can easily be relaxed by adding specific
> -Wno-xxx after the Xenomai flags. And *that* should happen explicitly.
>
> -pipe is an optimisation of the build process, something one may
> discuss, though I don't see an immediate reason why it could fail in the
> context of Xenomai applications (that should use the GNU toolchain 
anyway).

I definitley agree on the use of "-Wall" and "-pipe", but i think these
optional flags should be set in the main project, and not by external
libraries or tools. It's not that i think they would conflict with
other flags or that they are wrong or inappropriate, but just because
i expect *-config-tools to not specify any flags that affect the
compiler behaviour. I just don't want every libraries' config-script
to place the authors favorite compiler-flags into my own flags.


> PS: sed 's/-I.//' applied on xeno-config output may meanwhile save your
> day...

make's $(filter-out -I.,$(XENOMAICFLAGS)) works as well, thank you anyway 
;)

Thomas Wiedemann

diff -urN xenomai-2.2.0.orig/scripts/xeno-config.in 
xenomai-2.2.0/scripts/xeno-config.in
--- xenomai-2.2.0.orig/scripts/xeno-config.in   2006-06-23 11:23:24.000000000 
+0200
+++ xenomai-2.2.0/scripts/xeno-config.in        2006-10-04 13:29:12.000000000 
+0200
@@ -12,12 +12,12 @@
 XENO_PREFIX="${staging}${prefix}"
 XENO_CC="@CC@"
 XENO_TARGET_ARCH="@XENO_TARGET_ARCH@"
-XENO_BASE_CFLAGS="-I. -I${staging}${includedir} @XENO_USER_APP_CFLAGS@"
+XENO_BASE_CFLAGS="-I${staging}${includedir} @XENO_USER_APP_CFLAGS@"
 XENO_BASE_LDFLAGS="-L${staging}${libdir} -lpthread @XENO_USER_APP_LDFLAGS@"
-XENO_POSIX_CFLAGS="-I. -I${staging}${includedir} 
-I${staging}${includedir}/posix @XENO_USER_APP_CFLAGS@"
+XENO_POSIX_CFLAGS="-I${staging}${includedir} -I${staging}${includedir}/posix 
@XENO_USER_APP_CFLAGS@"
 XENO_POSIX_LDFLAGS="-L${staging}${libdir} -lpthread_rt -lpthread -lrt 
@XENO_USER_APP_LDFLAGS@"
 XENO_POSIX_WRAPPERS="${staging}${libdir}/posix.wrappers"
-XENO_UVM_CFLAGS="-I. -I${staging}${includedir} @XENO_USER_APP_CFLAGS@ 
-D__XENO_UVM__"
+XENO_UVM_CFLAGS="-I${staging}${includedir} @XENO_USER_APP_CFLAGS@ 
-D__XENO_UVM__"
 XENO_UVM_LDFLAGS="-u__xeno_skin_init -L${staging}${libdir} -luvm -lnucleus_uvm 
-lpthread"
 XENO_LIBRARY_DIR="${staging}${libdir}"
 
_______________________________________________
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core

Reply via email to