Merged:
* Spelling error (from nesciens/rfc-debian-patches)
* AUTHORS update (from anthonyg/master)
* Ruby NULL unref (from nesciens/master)
Updated:
nesciens/rfc-debian-patches
Most comments from last mail are still true.
As for the glib version check it is mostly good,
but will cause handle_image_comment to be unused
on older glib versions. I suggest moving the
b64 decoding into that function, and making two
variants of the functions depending on glib version.
Stubbed out on old glib versions.
nesciens/rfm-idlist-to-value-t
cf6afd1 leaves the tree broken. I guess you need to do
squash cf6, e6d and 9d8 into one commit to make sure it
doesn't leave tree broken.
Then please split 6b9 and 1fb into separate parts so e.g
{ruby,c++,perl} guys can look at {ruby,c++,perl} changes.
anthonyg/rfm-flv
"Cleanup":
for (i = 0; i < sizeof (flv_codecs); i++)
is wrong. use G_N_ELEMENTS
Which part is the infinite loop fix?
This would have been much easier to review if you did the
renaming of the constants in a separate commit?
juhovh/master
This static thing is strange? Are they doing some kind of magic
when compiling? Can we do the same magic to be as close to
upstream as possible?
Can any of our changes be sent upstream?
--
_______________________________________________
Xmms2-devel mailing list
[email protected]
http://lists.xmms.se/cgi-bin/mailman/listinfo/xmms2-devel
