On Sat, 17 Apr 2010 11:29:18 +0200
Anders Waldenborg <[email protected]> wrote:
> nesciens/rfc-debian-patches
>
> Most comments from last mail are still true.
> As for the glib version check it is mostly good,
> but will cause handle_image_comment to be unused
> on older glib versions. I suggest moving the
> b64 decoding into that function, and making two
> variants of the functions depending on glib version.
> Stubbed out on old glib versions.
So we go from
handle_image_comment (...) {...}
handle_comment (...) {
...;
#if GLIB_CHECK_VERSION(2,12,0)
decode (...);
handle_image_comment (...);
#endif
...
}
to
handle_image_comment (...) {
#if GLIB_CHECK_VERSION(2,12,0)
decode (...);
...;
#endif
}
handle_comment (...) {
...;
handle_image_comment (...);
...;
}
? Or am I not getting you?
I think I'll reject the supplied patch for Debian Bug 510375
(xmms2-launcher verbosity), and create a new patch intoducing a
-q/--quiet switch, so that no xmms2d-switch it shadowed. Is this okay
with the Debian-people?
I'll reject the "Fix binary-or-shlib-defines-rpath Lintian
warning"-patch because from xmms2 bugreport 1545 ("sid plugin fails to
configure if resid is not in library searth path") it seems that the
code that is removed, is needed for non-Debian systems.
I haven't a clue about what to do with the mp4 spelling error. I'll
keep it hovering until there is a decision on what to do with mp4
upstream.
According to http://www.gentoo.org/proj/en/qa/asneeded.xml a relatively
recent GNU LD is needed to use the --as-needed switch and it will not
work on FreeBSD. I'm rejecting the patch because failure to build will
occur on non-Debian systems.
The clientlib offers *_encoded functions which take encoded urls. There
is however no function to do the url encoding in the public API.
Adding this makes more sense to me than adding the prototype of
_xmmsc_medialib_encode_url to the medialib-updater. I'll write a patch
for this.
Regards,
Erik Massop / nesciens
--
_______________________________________________
Xmms2-devel mailing list
[email protected]
http://lists.xmms.se/cgi-bin/mailman/listinfo/xmms2-devel
