Am Sonntag, den 18.04.2010, 19:15 +0200 schrieb Erik Massop: 
> I think I'll reject the supplied patch for Debian Bug 510375
> (xmms2-launcher verbosity), and create a new patch intoducing a
> -q/--quiet switch, so that no xmms2d-switch it shadowed. Is this okay
> with the Debian-people?

I prefer a more silent xmms2-launcher by default. As stated in the bug
the launcher should only output error messages by default. Do you agree?

To avoid shadowing the xmms2d-switch let's rename the verbose parameter
for xmms2-launcher.

> I'll reject the "Fix binary-or-shlib-defines-rpath Lintian
> warning"-patch because from xmms2 bugreport 1545 ("sid plugin fails to
> configure if resid is not in library searth path") it seems that the
> code that is removed, is needed for non-Debian systems.

For which system is this needed? Can it be detected automatically?

> According to http://www.gentoo.org/proj/en/qa/asneeded.xml a relatively
> recent GNU LD is needed to use the --as-needed switch and it will not
> work on FreeBSD. I'm rejecting the patch because failure to build will
> occur on non-Debian systems.

Fine. Another solution that works everywhere is to fix these warnings:

dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if 
"debian/xmms2-core/usr/bin/xmms2d" were not uselessly linked against it (they 
use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-et/usr/bin/xmms2-et" were not uselessly linked against it (they 
use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/libxmmsclient-glib1/usr/lib/libxmmsclient-glib.so.1.0.0" were not 
uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libglib-2.0.so.0 could be avoided if 
"debian/libxmmsclient++-glib1/usr/lib/libxmmsclient++-glib.so.1.0.0" were not 
uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libxmmsclient.so.6 could be avoided if 
"debian/libxmmsclient++-glib1/usr/lib/libxmmsclient++-glib.so.1.0.0" were not 
uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libdl.so.2 could be avoided if 
"debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_glib.so 
debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_ext.so" 
were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libglib-2.0.so.0 could be avoided if 
"debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_glib.so" 
were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_glib.so 
debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_ext.so" 
were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if 
"debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_glib.so 
debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_ext.so" 
were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be avoided if 
"debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_glib.so 
debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_ext.so" 
were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libcrypt.so.1 could be avoided if 
"debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_glib.so 
debian/libxmmsclient-ruby1.8/usr/lib/ruby/1.8/x86_64-linux/xmmsclient_ext.so" 
were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/python-xmmsclient/usr/lib/pyshared/python2.6/xmmsclient/xmmsapi.so" 
were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-client-cli/usr/bin/xmms2" were not uselessly linked against it 
(they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-client-nycli/usr/bin/nyxmms2" were not uselessly linked against 
it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-client-avahi/usr/bin/xmms2-mdns-avahi" were not uselessly linked 
against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libgmodule-2.0.so.0 could be avoided if 
"debian/xmms2-client-medialib-updater/usr/bin/xmms2-mlib-updater" were not 
uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-client-medialib-updater/usr/bin/xmms2-mlib-updater" were not 
uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if 
"debian/xmms2-client-medialib-updater/usr/bin/xmms2-mlib-updater" were not 
uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be avoided if 
"debian/xmms2-client-medialib-updater/usr/bin/xmms2-mlib-updater" were not 
uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-plugin-mms/usr/lib/xmms2/libxmms_mms.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libogg.so.0 could be avoided if 
"debian/xmms2-plugin-vorbis/usr/lib/xmms2/libxmms_vorbis.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-plugin-faad/usr/lib/xmms2/libxmms_faad.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if 
"debian/xmms2-plugin-jack/usr/lib/xmms2/libxmms_jack.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be avoided if 
"debian/xmms2-plugin-jack/usr/lib/xmms2/libxmms_jack.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libcurl.so.4 could be avoided if 
"debian/xmms2-plugin-daap/usr/lib/xmms2/libxmms_daap.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-plugin-ices/usr/lib/xmms2/libxmms_ices.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be avoided if 
"debian/xmms2-plugin-ices/usr/lib/xmms2/libxmms_ices.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libdl.so.2 could be avoided if 
"debian/xmms2-plugin-ao/usr/lib/xmms2/libxmms_ao.so" were not uselessly linked 
against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-plugin-cdda/usr/lib/xmms2/libxmms_cdda.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libfftw3.so.3 could be avoided if 
"debian/xmms2-plugin-ofa/usr/lib/xmms2/libxmms_ofa.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-plugin-ofa/usr/lib/xmms2/libxmms_ofa.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libssl.so.0.9.8 could be avoided if 
"debian/xmms2-plugin-airplay/usr/lib/xmms2/libxmms_airplay.so" were not 
uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libgcc_s.so.1 could be avoided if 
"debian/xmms2-plugin-gme/usr/lib/xmms2/libxmms_gme.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libgmodule-2.0.so.0 could be avoided if 
"debian/xmms2-plugin-gvfs/usr/lib/xmms2/libxmms_gvfs.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libgthread-2.0.so.0 could be avoided if 
"debian/xmms2-plugin-gvfs/usr/lib/xmms2/libxmms_gvfs.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if 
"debian/xmms2-plugin-gvfs/usr/lib/xmms2/libxmms_gvfs.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be avoided if 
"debian/xmms2-plugin-gvfs/usr/lib/xmms2/libxmms_gvfs.so" were not uselessly 
linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/libaudio-xmmsclient-perl/usr/lib/perl5/auto/Audio/XMMSClient/XMMSClient.so"
 were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libdl.so.2 could be avoided if 
"debian/xmms2-client-vis/usr/bin/xmms2-libvisual" were not uselessly linked 
against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if 
"debian/xmms2-client-vis/usr/bin/xmms2-ripper 
debian/xmms2-client-vis/usr/bin/xmms2-libvisual" were not uselessly linked 
against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be avoided if 
"debian/xmms2-client-vis/usr/bin/xmms2-libvisual" were not uselessly linked 
against it (they use none of its symbols).

> The clientlib offers *_encoded functions which take encoded urls. There
> is however no function to do the url encoding in the public API.
> Adding this makes more sense to me than adding the prototype of
> _xmmsc_medialib_encode_url to the medialib-updater. I'll write a patch
> for this.

The _xmmsc_medialib_encode_url patch is just a hacky patch. A proper
solution is appreciated.

-- 
Benjamin Drung
Ubuntu Developer (www.ubuntu.com) | Debian Maintainer (www.debian.org)

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

--
_______________________________________________
Xmms2-devel mailing list
[email protected]
http://lists.xmms.se/cgi-bin/mailman/listinfo/xmms2-devel

Reply via email to