On Mon, Nov 29, 2010 at 08:57:37PM -0800, Alan Coopersmith wrote: > The meat of this series is sandwiched right in the middle - patch #6 > replaces the nifty, but unique, Xprintf() API with a local implementation > of the asprintf() family that's becoming widely adopted (found in > recent versions of the GNU, FreeBSD, NetBSD, OpenBSD, & Solaris > libc's, but not yet in all the versions & platforms we still support). > I believe I've relied on the least common denominator implementation > (i.e. always check for a -1 return for error, and don't rely on the > pointer being cleared to NULL on failure), so at some far future date, > when we no longer support pre-asprintf versions of these platforms, > we can simply do s/Xasprintf/asprintf/g and not break anything.
Nice! For the series, bearing in mind the comment on #7: Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
