On 26.03.2015 11:33, Eric Anholt wrote: > Michel Dänzer <[email protected]> writes: > >> On 26.03.2015 04:14, Eric Anholt wrote: >>> Michel Dänzer <[email protected]> writes: >>>> On 25.03.2015 05:21, Eric Anholt wrote: >>>>> >>>>> Keith Packard (13): >>>> [...] >>>>> glamor: Eliminate GLAMOR_USE_SCREEN and GLAMOR_USE_PICTURE_SCREEN >>>>> glamor: Remove _nf rendering functions >>>>> glamor: Remove ddx fallback check functions >>>> >>>> NAK for these changes. I'll be using the *_nf functions in the radeon >>>> driver soon, and I expect there might be interest for something similar >>>> in the modesetting driver and/or Xwayland in the long term as well. >>> >>> Can you elaborate on what you're planning on using them for? >> >> If it's really important to remove that stuff, there should be more >> justification than 'the intel driver no longer uses this', because it's >> still being used. > > Well, it's 550 out of our only 19700 lines of code. That's a pretty > good justification to me. > > The only reason _nf is useful is if you need to implement faster > software fallbacks -- otherwise, you should wrap above glamor, since _nf > would have been equivalent to calling down. What operations are falling > back that you need to be faster?
You have a point about wrapping above glamor, I'll try that. Can we put these three changes on hold in the meantime? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
signature.asc
Description: OpenPGP digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
