On 02/23/2017 07:59 PM, Adam Jackson wrote: > I pushed essentially this version of the patch (pos not gl_Position), > having not read far enough down in the mailbox to see this version. > (And, Dieter's right, picking on the little shit really is > counterproductive for one-liners.) > > That said, gl_Position is probably right. But I think dashing is broken > already, so at least now we're just rendering wrong instead of > crashing. If someone wants to get rendering correct too, please do...
Uh-oh - for me, this patch actually introduces another possibility to crash Xorg. I've compiled Xephyr from Git d8161aeb50891ae10c5656487ce8f982deed5f9f and then I ran the reproducer from this bug: https://bugs.freedesktop.org/show_bug.cgi?id=99708 The bug is totally unrelated AFAICT, but still: A simple program that barely draws a dashed line makes Xephyr crash. Can we revert the commit for the time being? Given that we had a discussion about the correctness of the GLAMOR line code in the bugs https://bugs.freedesktop.org/show_bug.cgi?id=99705 https://bugs.freedesktop.org/show_bug.cgi?id=99708 maybe we should reconsider switching to software rendering for now, at least as the default setting of an xorg.conf option... Max _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
