On Fre, 2011-11-04 at 16:42 +0100, Johannes Obermayr wrote:
> From: Stefan Dirsch <[email protected]>
While it's nice to have a reference to the bug report in the commit log,
it's not enough on its own. Especially not in cases like this, when the
bug report doesn't seem accessible to everybody, not even everybody with
a Novell account.
> diff --git a/src/radeon_driver.c b/src/radeon_driver.c
> index 2cfe36a..18f7a57 100644
> --- a/src/radeon_driver.c
> +++ b/src/radeon_driver.c
> @@ -222,6 +222,7 @@ struct RADEONInt10Save {
> uint32_t MEM_CNTL;
> uint32_t MEMSIZE;
> uint32_t MPP_TB_CONFIG;
> + unsigned char MISC_OUT;
Looks like space vs. tab indentation mismatch.
> if (!IS_AVIVO_VARIANT) {
> + OUTREG(0,RADEON_MEM_CNTL);
What's the purpose of this register write? If it's really needed, please
write it as OUTREG(RADEON_MM_INDEX, RADEON_MEM_CNTL) and maybe add a
comment about its purpose.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
xorg-driver-ati mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-driver-ati
