Denis> Hi Daniel, [..]
Denis> (By the way, one could modify the MRU logic so that the filename also gets inserted into the MRU only when the file is discarded, rather than when it is opened Denis> or assigned a name -- so, at the same time that we update the page number in the MRU. This would have the advantage of consolidating the calls to update the MRU Denis> into a single place. One drawback is that I personally like the first MRU entry in the menus be the current file, which can be useful to revert all unsaved Denis> changes or refresh a PDF background that was modified externally just by typing alt+f u 1 -- but this is perhaps not crucial). (Note, the "refresh PDF" usage of Denis> the MRU, if it is used more widely than just by myself, pleads for the idea that we in fact may want to update the page number in the MRU continuously, perhaps Denis> at do_switch_page() if ui.filename is non-NULL ?) thanks Denis, In general, the standard way to do this is to have a "Revert" option in the menu. It will be cleaner from the point of view of the user (and implementation too). One thing I noticed is that once I moved to a different page (using do_switch_page) it considers the file as modified, even if no change has occurred. I am not sure yet where that is happening. I'll have to look into it. --dmg ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel
