Hi Daniel,

> In general, the standard way to do this is to have a "Revert" option in
> the menu. It will be cleaner from the point of view of the user (and
> implementation too).

Hmm, but a menu entry called "revert xoj and update pdf" seems rather 
complicated conceptually. I guess we could call it "Reload file". Still 
not sure if it's much cleaner for the user. Implementation-wise, it's 
not particularly cleaner either: in fact we need to remember to 
disable/re-enable the menu item when editing a not-yet-saved xoj file 
that has no PDF background, and handle separately the case of annotating 
a PDF but not having saved a .xoj file yet.

> One thing I noticed  is that once I moved to a different page (using
> do_switch_page) it considers the file as modified, even if no change has
> occurred.  I am not sure yet where that is happening. I'll have to look
> into it.

Strange, I'm pretty sure that nothing under do_switch_page() should ever 
change the value of ui.saved ?

Denis

-- 
Denis Auroux
UC Berkeley, Department of Mathematics     aur...@math.berkeley.edu 

Institut Henri Poincare, Paris             aur...@ihp.fr

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Xournal-devel mailing list
Xournal-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xournal-devel

Reply via email to