Hi Denis, Denis Auroux twisted the bytes to say:
Denis> Thanks for the work on saving pages in the MRU! I don't have Denis> time to review the patch carefully at the moment, but at least Denis> I've downloaded and played with it and it seems to do the right Denis> thing. I'll keep testing it. I also have to set my laptop to build windows, and I'll be able to tell how well/bad it behaves under Windows. Denis> [metadata use for saving last page] >> Denis, if you use Linux, I think you will like it. It is basically the >> logic we discussed (saving the last page accessed) without altering the >> xournal file. One thing we could do is to add a flag so this is saved >> only when the user wants it (and none by default). Denis> At the moment I'm still a bit unhappy with the concept of gvfs Denis> metadata that gets magically stored in a completely obscure Denis> location and format -- I find a lot of the gvfs magic rather Denis> evil -- but if the GIO API hides the backend mechanism and works Denis> seamlessly on systems that don't have gvfs then I guess I'll Denis> eventually be able to live with it -- just need some time to Denis> adjust to the idea. I was too before I discovered what it was. Evince does some evil things, like resetting the location of the window on a file basis. I thought it was my window manager! But it seems to be the cleanest place to put the currentPage data. And the code is robust: if gvfs cannot be used for any reason, it doesn't do anything. Denis> However: presumably we don't need to store page numbers both in Denis> the MRU file and in gvfs metadata? Presumably we should choose At this point, yes. The logic is the following: - Open file - If currrentpage in metadata, the open it in that page - If the file was open via MRU, switch to page according to MRU I thought about whether we only needed one, but I quickly discovered that they can behave differently. For example, if you open a file via the File/Open menu, it does not use MRU. But as I said before we can easily disable it if gvfs is available. Denis> one -- windows compatibility seems to suggest the MRU file is Denis> better, though multi-instance issues suggest the gvfs metadata Denis> is better if we don't want to handle conflicts between multiple Denis> instances of xournal keeping their own MRU lists? Yes, the MRU is simple solution for windows. >> But there is one message that i get every time I open a xournal that has >> annotations and I want to jump to a different page (see attachment): >> "Save this version and delete auto-save?" But I have autosave enabled, >> so I still dont' know where this message comes from. Denis> I don't get this message when testing your branch, but I did get Denis> it briefly for one particular file that I had been editing a Denis> couple of weeks ago, and then it went away after a few times of Denis> getting this message. This was with the "normal" version of Denis> xournal. So there's perhaps a bug somewhere that only happens Denis> sporadically and perhaps got triggered independently of your Denis> changes to the code (or maybe was made more likely to happen by Denis> them?) [...] Denis> (I'd gladly do that myself, but I can't reproduce the bug...) No worries. I'll try to find out what it is. Also, now that we have been working on pages. Long time ago I added command line options to my branch. the main reason was to the ability to jump to a given page (very useful when you run xournal from the command line). What do you think about this? The idea would be to use the glib library to parse options and add an option: --page N to jump to the N-th page in the document (or the last one if N > page numbers). These were all the options I implemented: -p, --page=N Jump to Page -e, --export-pdf=FILENAME Export document to a PDF file (exit after) --fullscreen Run xournal in full screen I have to add that this morning I was thinking it would be neat to have an option to run the background screenshot from the command line. This way I can make it a shortcut to the window manager. If I am teaching and I want to highlight something, I could just run the shortcut, and bam! xournal with a screenshot of the selected window --dmg -- Daniel M. German "The problem in the old days when you were working with one piece of film is, Jeff Wall -> it's like triage, you had to take the least bad." http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel