On Tue, 2001-12-04 at 11:27, Adrian Cox wrote: > Derrik Pates wrote: > > > I finally determined why it is that the XFree Rage128 driver always gets > > the wrong framebuffer row width. In XFree 4.1.0's source, in > > xc/programs/Xserver/hw/xfree86/drivers/ati/r128_driver.c, lines 1105 to > > 1118 call XF86ValidateModes with a minPitch of 8 * 64 (512) and a max > > pitch of 8 * 1024 (8192). The default pitch increment value is 64 * > > pScrn->bitsPerPixel, such that the row width is ALWAYS a multiple of 64. > > > I've confirmed that this fixes the problems with 800x600 mode on my > iBook2 and attached it as a patch. Can somebody please apply this (or > come up with an argument as to why it's wrong)?
It's wrong because the register reference says the pitch must be a multiple of 64 bytes. I already submitted a patch to that effect. 800x600 in depth 8 is still broken though. Something obviously can't handle the pitch not being equal to virtualX*bitsPerPixel/8, but I couldn't find any mistake in the r128 driver. Which doesn't mean there isn't one. :) -- Earthling Michel D�nzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast _______________________________________________ Xpert mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/xpert
