>> I don't think there are any issues with the blit engine at 16 bit.

>Is there an i810 blitter bug at 24bpp? (and that's what the author of the
>code was referring to?)

Yes, I believe there is a 24bpp problem. Most of the i810 only runs at 16bit
so the normal use case has always been 16bit.

>But if your theory is correct, and the source pitch was wildly incorrect,
>wouldn't nearly all blits be corrupted?

No, blits from the Framebuffer to the Framebuffer would be correct. Blits
from
the pixmap cache to the framebuffer that are only 1 line would also be
correct.

>One silly thing I noticed is that the code used to write the blitter
>source pitch to the ring buffer in I810SubsequentScreenToScreenCopy:
>
>     OUT_RING( pI810->BR[13] & 0xFFFF );
>
>should really only write 13 bits, 14-32 are reserved according to my copy
>of the specs.  Does the i810 get cranky about its reserved bits?

That isn't a problem. Bits like that are usually reserved to make room for
larger values in possible future chipsets without having to move bits
around.
I'm sure it is fine.


I checked the code again and I'm still thinking the problem is with the data
getting stored into the cache. That seems to be in the Xaa code, not the
i810 code so it is possible that the pitches are not in sync.

-Matt
_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert

Reply via email to