[Xpert]RE: i810 fb memory manager patch

[Bill Soudan]

On Wed, 25 Sep 2002, Jeff Hartmann wrote:

>       This is just a hunch but I'm wondering if this could be a previously
> undetected problem in the XFree86 memory manager.  I want you people who can
> reproduce the problem to try the above patch and tell me if it works.  I
> unfortunately no longer have access to an i810 or i815 (or i830 or i845 for
> that matter.)  So I can't test this to see if it works.  If it does there is
> a problem with the memory manager using the leftover bit of memory on the
> side of the screen.  Its probably very rare to hit the path and probably
> just a small calculation thats off somewhere.  If this patch works it gives
> you a good data point at any rate, one thing which is not causing the
> problem.

The patch as is causes a core, xf86InitFBManagerRegion expects a
RegionPtr, not a BoxPtr.  If you meant this:

   {
      BoxRec box;
      RegionRec region;

      box.x1 = 0;
      box.x2 = pScrn->displayWidth;
      box.y1 = pScrn->virtualY;
      box.y2 = pI810->FbMemBox.y2;

      REGION_INIT(pScreen, &region, &box, 1 /* ??? */);

      if (!xf86InitFBManagerRegion(pScreen, &region)) {
        xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
                "Failed to init memory manager\n");
        return FALSE;
      }
   }

Then no, the patch unfortunately doesn't solve the problem.  Though I do 
see that Xaa reports less available tile & stipple cache entries.

Shouldn't the regular xf86InitFBManager function automatically remove the 
screen RAM?

Bill

_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert