Martin Bochnig wrote:
> Okay, so you have done a good job in adjusting wsfb_driver.c from BSD to 
> Solaris / to translate BSD's wsfb ioctl()'s to what Solaris' console drivers 
> normally offer, at least _some_ of them offer, unfortunately not all, as 
> FBIOGXINFO is not mandatory for such a driver (according to docs.sun.com), 
> and may therefore be missing in certain cases, as we saw in terms of PGX32's 
> gfxp.
> A generic driver such as wsfb should not depend on the presence of 
> _any_single_ ioctl().

I don't understand - how else can it possibly work then?

> ### So to to conclude:
> 
> # FBIOGXINFO is not device specific per se, but some console drivers just 
> don't offer it 
> (at  least one, gfxp)
> # I don't see a better translation from BSD's WSDISPLAYIO_LINEBYTES to 
> Solaris, than FBIOGXINFO, so well done!
> # we have to get rid of ioctl's for wsfb, as we have to be as generic with 
> our expectations, as possible

wsfb is mainly intended as a way to get a working Xorg up for testing purposes.
I would hope eventually that no one ever runs it, but is instead running a
hardware specific driver, but for the short term I made do as best I could
(and am sure anyone could make it better by putting a few more hours into it,
  I just haven't taken the time beyond the initial work of bringing it up).

> Alan, why didn't you just correct me where I made wrong wsfb_drv related 
> _guesses_ that night?

Sorry, which guesses are you referring to?   I'm not sure what you're
talking about.

-- 
        -Alan Coopersmith-           alan.coopersmith at sun.com
         Sun Microsystems, Inc. - X Window System Engineering


Reply via email to