[ 
https://issues.apache.org/jira/browse/YARN-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626007#comment-15626007
 ] 

Wangda Tan commented on YARN-5587:
----------------------------------

Thanks [~vvasudev] for the detailed information,

bq. Apply any override specified in the profile capability override over the 
profile resources
I'm not quite sure about how to apply override capacity, will it override all 
the fields or only non-zero fields: For example, assume {{small}} profile is 
<4G, 1 vcore,  1 disk>, and override is <8G, 2 vcore>, what should be the final 
resource? <8G, 2 vcore, 0 disk> or <8G, 2 vcore, 1 disk>?

>From the ProfileCapability#toResource, it is the latter one. Probably it is 
>better to add a javadocs to ProfileCapability#getProfileCapabilityOverride. I 
>cannot find clear explanations from Javadoc of ProfileCapability.

bq. However at some point, I would like to deprecate Capability.
Make sense to keep API design as-is if the original capability field will be 
deprecated.

Other comments all make sense to me.

My last question is, after this patch goes in, which patches are required for 
end-to-end feature completed and testable?

> Add support for resource profiles
> ---------------------------------
>
>                 Key: YARN-5587
>                 URL: https://issues.apache.org/jira/browse/YARN-5587
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>              Labels: oct16-hard
>         Attachments: YARN-5587-YARN-3926.001.patch, 
> YARN-5587-YARN-3926.002.patch, YARN-5587-YARN-3926.003.patch, 
> YARN-5587-YARN-3926.004.patch, YARN-5587-YARN-3926.005.patch, 
> YARN-5587-YARN-3926.006.patch, YARN-5587-YARN-3926.007.patch, 
> YARN-5587-YARN-3926.008.patch
>
>
> Add support for resource profiles on the RM side to allow users to use 
> shorthands to specify resource requirements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to