[ 
https://issues.apache.org/jira/browse/YARN-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641066#comment-15641066
 ] 

Arun Suresh commented on YARN-5587:
-----------------------------------

Thanks for updating the patch [~vvasudev]... Apologize for the delay in coming 
round to this.

bq. question about RemoteRequestsTable - is it meant to be public to AMs or can 
we change APIs for it without any issues?
I had intended it to be just a utility for {{AMRMClientImpl}}. Not really meant 
to be public API. Do you think it would be generally useful ?

The changes in the AMRMClient look good. It would be nice if you could maybe 
add one testcase in the TestAMRMClient that runs thru the new 
ProfileCapabilityComparator. Maybe one where two requests each with 2 different 
ProfileCapabilities (but where both equate to each other) are provided and the 
getMatchingRequests such return both in the same call.

+1 pending the above


> Add support for resource profiles
> ---------------------------------
>
>                 Key: YARN-5587
>                 URL: https://issues.apache.org/jira/browse/YARN-5587
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>              Labels: oct16-hard
>         Attachments: YARN-5587-YARN-3926.001.patch, 
> YARN-5587-YARN-3926.002.patch, YARN-5587-YARN-3926.003.patch, 
> YARN-5587-YARN-3926.004.patch, YARN-5587-YARN-3926.005.patch, 
> YARN-5587-YARN-3926.006.patch, YARN-5587-YARN-3926.007.patch, 
> YARN-5587-YARN-3926.008.patch, YARN-5587-YARN-3926.009.patch, 
> YARN-5587-YARN-3926.010.patch, YARN-5587-YARN-3926.011.patch
>
>
> Add support for resource profiles on the RM side to allow users to use 
> shorthands to specify resource requirements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to