[ 
https://issues.apache.org/jira/browse/YARN-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629384#comment-15629384
 ] 

Varun Vasudev commented on YARN-5587:
-------------------------------------

{quote}
I'm not quite sure about how to apply override capacity, will it override all 
the fields or only non-zero fields: For example, assume small profile is <4G, 1 
vcore, 1 disk>, and override is <8G, 2 vcore>, what should be the final 
resource? <8G, 2 vcore, 0 disk> or <8G, 2 vcore, 1 disk>?
{quote}
The final resource will be <8G, 2 vcore, 1 disk>. The override is meant to let 
you override individual resource types. In practice, this will mean that users 
can override memory and vcores since those are the only resource types AMs 
currently expose to the user.

{quote}
>From the ProfileCapability#toResource, it is the latter one. Probably it is 
>better to add a javadocs to ProfileCapability#getProfileCapabilityOverride. I 
>cannot find clear explanations from Javadoc of ProfileCapability.
{quote}
Fair point - I'll fix the docs.

bq. My last question is, after this patch goes in, which patches are required 
for end-to-end feature completed and testable?

After this patch, only changes to the distributed shell AM and MR AM are 
required to test the feature end to end.

If the current approach is ok by you, I'll clean up the patch and upload a new 
one.


> Add support for resource profiles
> ---------------------------------
>
>                 Key: YARN-5587
>                 URL: https://issues.apache.org/jira/browse/YARN-5587
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>              Labels: oct16-hard
>         Attachments: YARN-5587-YARN-3926.001.patch, 
> YARN-5587-YARN-3926.002.patch, YARN-5587-YARN-3926.003.patch, 
> YARN-5587-YARN-3926.004.patch, YARN-5587-YARN-3926.005.patch, 
> YARN-5587-YARN-3926.006.patch, YARN-5587-YARN-3926.007.patch, 
> YARN-5587-YARN-3926.008.patch
>
>
> Add support for resource profiles on the RM side to allow users to use 
> shorthands to specify resource requirements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to