[
https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648602#comment-15648602
]
Sunil G commented on YARN-5611:
-------------------------------
Thanks [~rohithsharma] for the patch..
*Few more comments.*
1. {{ApplicationClientProtocol#updateApplicationTimeouts}} .Could this be an
Evolving api?.
2. {{ApplicationClientProtocolPBClientImpl#updateApplicationTimeouts}}. Does
exception handling block needs return? RPCUtil method will throw exception,
correct?
3. In {{ApplicationClientProtocolPBServiceImpl#updateApplicationTimeouts}}, we
use {{catch (YarnException| IOException e)}}.
4. On a different note, i think COMPLETED_APP_STATES could be defined by
RMAppImpl itself and expose a read-only api. This can help to cleanup local
states definitions. could be done in another patch.
5. Given a writeLock in {{RMAppImpl#updateApplicationTimeout}}, why do we need
another lock in RMAppManager#updateApplicationTimeout. Is this to handle some
race conditions while app update event is waiting in StateStore dispatcher
queue? I would love to have some more comments in these synchronized blocks or
write locks to give a brief explanation. It will help us later.
6. RMApp is generally considered as read-only. updateApplicationTimeout will
violate that. we can place this api in RMAppImpl itself, and in client side, we
could convert to RMAppImpl object and use. ProportionPolicy, New Global
Scheduler etc are using this way.
7. Timeout is to be part of ApplicationReport correct? Is that a part of this
patch?
> Provide an API to update lifetime of an application.
> ----------------------------------------------------
>
> Key: YARN-5611
> URL: https://issues.apache.org/jira/browse/YARN-5611
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: oct16-hard
> Attachments: 0001-YARN-5611.patch, 0002-YARN-5611.patch,
> 0003-YARN-5611.patch, YARN-5611.0004.patch, YARN-5611.0005.patch,
> YARN-5611.0006.patch, YARN-5611.0007.patch, YARN-5611.0008.patch,
> YARN-5611.v0.patch
>
>
> YARN-4205 monitors an Lifetime of an applications is monitored if required.
> Add an client api to update lifetime of an application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
