[ 
https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649497#comment-15649497
 ] 

Bibin A Chundatt commented on YARN-5611:
----------------------------------------

Thank you [~rohithsharma] for patch

Few Minor comments

# {{YarnConfiguration.DEFAULT_RM_APPLICATION_LIFETIME_MONITOR_INTERVAL_MS}} 
variable name can also be updated.
# Since multiple application timeout we might support in future can move to 
separate {{AppTimeoutDignostics}}
{code}
79          String diagnostics =
80              "Application killed due to exceeding its lifetime period";
{code}
# Timeline server update during update of timeout also we might have to handle 
{quote}
UpdateApplicationTimeoutsRequest takes appId and Map<ApplicationTimeoutType, 
Long> to update timeout values. And these timeout values are gets added to 
existing timeouts out. If application was not monitored, then this application 
start monitoring from now.
{quote}
# Application timeout is set to 0 and then start monitoring is it possbile can 
we add a testcase

> Provide an API to update lifetime of an application.
> ----------------------------------------------------
>
>                 Key: YARN-5611
>                 URL: https://issues.apache.org/jira/browse/YARN-5611
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>              Labels: oct16-hard
>         Attachments: 0001-YARN-5611.patch, 0002-YARN-5611.patch, 
> 0003-YARN-5611.patch, YARN-5611.0004.patch, YARN-5611.0005.patch, 
> YARN-5611.0006.patch, YARN-5611.0007.patch, YARN-5611.0008.patch, 
> YARN-5611.v0.patch
>
>
> YARN-4205 monitors an Lifetime of an applications is monitored if required. 
> Add an client api to update lifetime of an application. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to