[
https://issues.apache.org/jira/browse/YARN-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658396#comment-15658396
]
Jian He commented on YARN-5865:
-------------------------------
thanks Sunil, one comment:
we should make sure update in store first in case store operation failed, so "
rmApp.getApplicationSubmissionContext().setPriority(appPriority);" should be
done after
{code}
// Update new priority in Submission Context to keep track in HA
rmApp.getApplicationSubmissionContext().setPriority(appPriority);
// Update to state store
ApplicationStateData appState = ApplicationStateData.newInstance(
rmApp.getSubmitTime(), rmApp.getStartTime(),
rmApp.getApplicationSubmissionContext(), rmApp.getUser(),
rmApp.getCallerContext());
appState.setApplicationTimeouts(rmApp.getApplicationTimeouts());
rmContext.getStateStore().updateApplicationStateSynchronously(appState,
false, future);
{code}
> Retrospect updateApplicationPriority api to handle state store exception in
> align with YARN-5611
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-5865
> URL: https://issues.apache.org/jira/browse/YARN-5865
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: YARN-5865.0001.patch
>
>
> Post YARN-5611, revisit dynamic update of application priority logic with
> respect to state store error handling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
