[
https://issues.apache.org/jira/browse/YARN-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667503#comment-15667503
]
Rohith Sharma K S commented on YARN-5865:
-----------------------------------------
some more comments on the patch
AppInfo.java
# After current patch change, you can remove
app.getApplicationSubmissionContext();
RMAppManager.java
# line 401, 402, 403 has not changed. Looks like format has changed. Can you
revert this ?
# line 571, can you check if (app.isAppInCompletedStates()) immediately after
holding applicationId lock? It is not an issue, just not to create future
object.
# line 580, can you flip code for checking priority equals and do futures.get
like below?
{code}
if (app.getApplicationPriority().equals(appPriority)) {
return;
}
Futures.get(future, YarnException.class);
{code}
RMApp.java
# Java doc for API isAppInCompletedStates is repeated i.e *completed/completed
states*. It should be completing/completed.
YarnScheduler.java
# Return type of API has changed from void to Priority. I am not sure does it
breaks. cc:/[~jianhe]
> Retrospect updateApplicationPriority api to handle state store exception in
> align with YARN-5611
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-5865
> URL: https://issues.apache.org/jira/browse/YARN-5865
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: YARN-5865.0001.patch, YARN-5865.0002.patch,
> YARN-5865.0003.patch, YARN-5865.0004.patch, YARN-5865.0005.patch
>
>
> Post YARN-5611, revisit dynamic update of application priority logic with
> respect to state store error handling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
