[
https://issues.apache.org/jira/browse/YARN-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663486#comment-15663486
]
Rohith Sharma K S commented on YARN-5865:
-----------------------------------------
Thanks [~sunilg] for the patch. It looks all the reader API has changed to new
interface. I am fine with that.
One quick comment on patch is
# In CapacityScheduler#updateApplicationPriority, line no 2424, you are
returning the appPriority. But future is not set to null. This lead to
RMAppManager#updateApplicationPriority {{Futures.get(future,
YarnException.class);}} to hang. So, you need to set to null before returning
from scheduler. Better add a comment that you need to set to null or else it
will hang. May be you can test by updating priority same as earlier which lead
to test case hang.
> Retrospect updateApplicationPriority api to handle state store exception in
> align with YARN-5611
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-5865
> URL: https://issues.apache.org/jira/browse/YARN-5865
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: YARN-5865.0001.patch, YARN-5865.0002.patch
>
>
> Post YARN-5611, revisit dynamic update of application priority logic with
> respect to state store error handling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
