[ 
https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713505#comment-15713505
 ] 

Li Lu commented on YARN-5756:
-----------------------------

Thanks [~xgong] for the patch! Generally fine, some comments:

QueueState.java
  - STOP_RUNNING state is a little bit confusing? How about RUNNING, CLOSED (or 
DRAINING), and STOPPED? 
  - Java doc inconsistencies: at the very beginning of the enum we said there 
are only two possible states? 

QueueStateManager.java
  - Consistency issues with stop and activate queue? We're using fine grained 
locking to change each queue's status. We need to make the process of stopping 
each queue and its subqueues atomic (as in concurrency, not in db). Otherwise, 
concurrent activate queue calls may result in inconsistent results. If coarse 
grained locking is fine with the current use case, we may want to make 
activateQueues and stopQueues synchronized? 
  - QueueStateManager only needs the queue mapping in SchedulerQueueManager, so 
we do not need to reference the whole SchedulerQueueManager here? I don't have 
a strong opinion here though...

> Add state-machine implementation for queues
> -------------------------------------------
>
>                 Key: YARN-5756
>                 URL: https://issues.apache.org/jira/browse/YARN-5756
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-5756.1.patch, YARN-5756.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to