[ 
https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762758#comment-15762758
 ] 

Wangda Tan commented on YARN-5756:
----------------------------------

Thanks [~xgong], generally looks good, only one comment, could you add some 
test cases to make sure {{initializeQueueState}} works well?
I'm afraid regression could easily happen for any change to the method.

> Add state-machine implementation for queues
> -------------------------------------------
>
>                 Key: YARN-5756
>                 URL: https://issues.apache.org/jira/browse/YARN-5756
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-5756.1.patch, YARN-5756.2.patch, YARN-5756.3.patch, 
> YARN-5756.4.patch, YARN-5756.5.patch, YARN-5756.6.patch, YARN-5756.6.patch, 
> YARN-5756.7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to