[
https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726717#comment-15726717
]
Wangda Tan commented on YARN-5756:
----------------------------------
Thanks [~xgong], some comments/questions.
General:
- Could you add some descriptions to YARN-5755 and YARN-5724 as mentioned by
QueueStateManager
1) QueueStateManager:
- queueContext -> queueManager
- Move AbstractCSQueue#initializeQueueState to QueueStateManager? (Which we can
protect all state transitions under the same sync lock)
appFinished needs sync lock.
2) AbstractCSQueue
{code}
private ReentrantReadWriteLock.ReadLock queueStateReadLock;
private ReentrantReadWriteLock.WriteLock queueStateWriteLock;
{code}
Is not necessary since {{state}} is volatile
3) Implementation of initializeQueueState
- I'm not sure if initializeQueueState should be called when admin refreshes
queue config. If we plan to do so, initializeQueueState should be invoked when
reinitialize the queue, so you may need to move it to {{setupQueueConfigs}}.
- And in addition, if initializeQueueState will be called when admin refreshes
queue config, we need to handle state-in-memory and state-from-config, for
example, draining state.
> Add state-machine implementation for queues
> -------------------------------------------
>
> Key: YARN-5756
> URL: https://issues.apache.org/jira/browse/YARN-5756
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-5756.1.patch, YARN-5756.2.patch, YARN-5756.3.patch,
> YARN-5756.4.patch, YARN-5756.5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
