[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714710#comment-15714710
]
Sunil G commented on YARN-5956:
-------------------------------
Adding few more possible cleanups:
- COMPLETED_APP_STATES and ACTIVE_APP_STATES states are locally defined here.
This ideally has to come from RMAppImpl. There are few apis in RMAppImpl as of
today, we could try to use RMApp#isAppInCompletedStates, isAppInFinalState etc.
Its better if these are coming from RMApp itself.
- signalToContainer javadoc could be corrected with param and return
> Refactor ClientRMService
> ------------------------
>
> Key: YARN-5956
> URL: https://issues.apache.org/jira/browse/YARN-5956
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 3.0.0-alpha2
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Attachments: YARN-5956.01.patch
>
>
> Some refactoring can be done in {{ClientRMService}}.
> - Remove redundant variable declaration
> - Fill in missing javadocs
> - Proper variable access modifier
> - Fix some typos in method name and exception messages
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
