[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15721663#comment-15721663
]
Sunil G commented on YARN-5956:
-------------------------------
[~lewuathe]
few comments.
1.
{code}
if (application.isAppInCompletedStates()) {
RMAuditLogger.logSuccess(callerUGI.getShortUserName(),
AuditConstants.FAIL_ATTEMPT_REQUEST, "ClientRMService"
applicationId);
return response;
}
{code}
For {{failApplicationAttempt}}, this is not correct. We want to send normal
response only for those apps whihc are in final states. But if app is in
NEW_SAVING etc, we must throw exception. That is missed now.
2. {{updateApplicationTimeouts}} has some unwanted code. Pls remove it.
{code}
1634 if (application.isAppInCompletedStates()) {
1635
1636 }
{code}
> Refactor ClientRMService
> ------------------------
>
> Key: YARN-5956
> URL: https://issues.apache.org/jira/browse/YARN-5956
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 3.0.0-alpha2
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Attachments: YARN-5956.01.patch, YARN-5956.02.patch
>
>
> Some refactoring can be done in {{ClientRMService}}.
> - Remove redundant variable declaration
> - Fill in missing javadocs
> - Proper variable access modifier
> - Fix some typos in method name and exception messages
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
