[
https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15718125#comment-15718125
]
Kai Sasaki commented on YARN-5956:
----------------------------------
I updated the patch but keeps {{ACTIVE_APP_STATES}} as it is.
{quote}
COMPLETED_APP_STATES and ACTIVE_APP_STATES states are locally defined here.
This ideally has to come from RMAppImpl.
{quote}
It might be difficult to define {{ACTIVE_APP_STATES}} as public in
{{RMAppImpl}} because the class is an implementation not an interface.
Implementing an API like {{RMApp#isActiveState}} can be an option but it
requires the change of interface. It cannot be done as refactoring I think. So
keep {{ACTIVE_APP_STATES}} as it is can be a reasonable way. We should do that
in another track if necessary.
> Refactor ClientRMService
> ------------------------
>
> Key: YARN-5956
> URL: https://issues.apache.org/jira/browse/YARN-5956
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 3.0.0-alpha2
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Attachments: YARN-5956.01.patch, YARN-5956.02.patch
>
>
> Some refactoring can be done in {{ClientRMService}}.
> - Remove redundant variable declaration
> - Fill in missing javadocs
> - Proper variable access modifier
> - Fix some typos in method name and exception messages
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
