[
https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729687#comment-15729687
]
Sangjin Lee commented on YARN-4675:
-----------------------------------
Let's separate the discussion on what to do with the interface
({{TimelineClient}}) from the implementations ({{TimelineClientImpl}}).
I looked at the current interface, and as [~varun_saxena] said the
{{*DelegationToken}} methods are potential common methods shared between v.1
and v.2. However, the rest of the methods are specific to either v.1 or v.2.
Duplicating the same methods are bit unsatisfactory, but having to declare
methods as unsupported in the implementation (the current state) is probably
uglier.
In the implementation, I agree with [~gtCarrera9] that there are ways to
isolate the common code and have the v.1 and v.2 impls reuse that code without
using subclassing.
What do others think?
> Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl
> --------------------------------------------------------------------
>
> Key: YARN-4675
> URL: https://issues.apache.org/jira/browse/YARN-4675
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Labels: YARN-5355, oct16-medium
> Attachments: YARN-4675-YARN-2928.v1.001.patch
>
>
> We need to reorganize TimeClientImpl into TimeClientV1Impl ,
> TimeClientV2Impl and if required a base class, so that its clear which part
> of the code belongs to which version and thus better maintainable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
