[
https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732837#comment-15732837
]
Varun Saxena commented on YARN-4675:
------------------------------------
I am fine with the separation as well.
Probably it did not come out clearly in my previous comment but I was not
suggesting that common parts need to be subclassed. I was infact saying that
subclassing may not be possible. And common code can probably be put into
another helper class which can be called via implementations.
Agree that get and renew delegation token parts related to ATSv1 can be
added/called in ATSv2, as and when required. If we do use delegation tokens
this is likely to be exact same code though.
> Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl
> --------------------------------------------------------------------
>
> Key: YARN-4675
> URL: https://issues.apache.org/jira/browse/YARN-4675
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Labels: YARN-5355, oct16-medium
> Attachments: YARN-4675-YARN-2928.v1.001.patch
>
>
> We need to reorganize TimeClientImpl into TimeClientV1Impl ,
> TimeClientV2Impl and if required a base class, so that its clear which part
> of the code belongs to which version and thus better maintainable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
