[
https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825753#comment-15825753
]
Yufei Gu commented on YARN-5830:
--------------------------------
[~kasha], thanks a lot for your detailed review. Uploaded patch 004 for all
your comments. Some comments:
- {{moveNonAMContainerFirst}} is replaced by
{{SchedulerNode#getCopiedListOfRunningContainersWithAMInEnd}}
- Put {{node.addContainersForPreemption()}} in {{preemptContainers()}} because
I think it is logically close to code in {{preemptContainers()}}.
> Avoid preempting AM containers
> ------------------------------
>
> Key: YARN-5830
> URL: https://issues.apache.org/jira/browse/YARN-5830
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Karthik Kambatla
> Assignee: Yufei Gu
> Attachments: YARN-5830.001.patch, YARN-5830.002.patch,
> YARN-5830.003.patch, YARN-5830.004.patch
>
>
> While considering containers for preemption, avoid AM containers unless
> absolutely necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
