[ 
https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836439#comment-15836439
 ] 

ASF GitHub Bot commented on YARN-5830:
--------------------------------------

Github user kambatla commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/180#discussion_r97618432
  
    --- Diff: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairSchedulerPreemption.java
 ---
    @@ -285,4 +309,43 @@ public void testNoPreemptionFromDisallowedQueue() 
throws Exception {
         submitApps("root.nonpreemptable.child-1", "root.preemptable.child-1");
         verifyNoPreemption();
       }
    +
    +  /**
    +   * Set the number of AM containers for each node.
    +   *
    +   * @param numAMContainersPerNode number of AM containers per node
    +   */
    +  private void setNumAmContainersPerNode(int numAMContainersPerNode) {
    --- End diff --
    
    Nit: I would prefer setNumAMContainersPerNode.


> Avoid preempting AM containers
> ------------------------------
>
>                 Key: YARN-5830
>                 URL: https://issues.apache.org/jira/browse/YARN-5830
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Karthik Kambatla
>            Assignee: Yufei Gu
>         Attachments: YARN-5830.001.patch, YARN-5830.002.patch, 
> YARN-5830.003.patch, YARN-5830.004.patch, YARN-5830.005.patch, 
> YARN-5830.006.patch
>
>
> While considering containers for preemption, avoid AM containers unless 
> absolutely necessary. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to