[
https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827067#comment-15827067
]
Karthik Kambatla commented on YARN-5830:
----------------------------------------
Patch looks mostly good. Few nits:
# SchedulerNode
## javadoc s/"in the end"/"at the end".
## javadoc s/"running containers in the node"/"containers running on the node".
## javadoc @return "a copy of running containers with AM containers at the end.
## Maybe rename method to "getRunningContainersWithAMsAtTheEnd"?
# FSPreemptionThread#identifyContainersToPreemptOnNode javadoc
## s/"by one given node"/"on a given node"
## This method returns a non-null set of containers only if the number of AM
containers is less than max.
## @param maxAMContainer - rename to maxAMContainers, update javadoc to say max
allowed AM containers in the set.
## @return could be shorter - list of preemptable containers with fewer AM
containers than maxAMContainers if such a list exists; null otherwise.
# PreemptableContainers javadoc: s/trace/track
# TestFairSchedulerPreemption
## setAmContainerNumPerNode: Rename to setNumAMContainersPerNode. javadoc has
two instances of singular container, change to "containers". Change param to
numAMContainersPerNode
## testPreemptionSelectAMContainers: s/are only/is only
Good call on moving the call to SchedulerNode#addContainersForPreemption to
preemptContainers.
> Avoid preempting AM containers
> ------------------------------
>
> Key: YARN-5830
> URL: https://issues.apache.org/jira/browse/YARN-5830
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Karthik Kambatla
> Assignee: Yufei Gu
> Attachments: YARN-5830.001.patch, YARN-5830.002.patch,
> YARN-5830.003.patch, YARN-5830.004.patch
>
>
> While considering containers for preemption, avoid AM containers unless
> absolutely necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
