[
https://issues.apache.org/jira/browse/YARN-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854574#comment-15854574
]
Naganarasimha G R commented on YARN-5703:
-----------------------------------------
Thanks for some of the clarification [[email protected]], but i would
suggest the following:
# AbstractReservationSystem, ln no 456: no need to cross check with
{{ReservationAgent.class.isAssignableFrom(agentClazz)}}, as {{conf.getClass}}
takes care of it.
# ??in ReservationAgent.java. If I don't specify right sub class, those
constants and its getters won't be available? Do you see any issues here?? :
Have static methods in {{ReservationSchedulerConfiguration}} which accepts
configuration as param and fetch the required information (refer methods in
YarnConfiguration )
# ??Yes, configurable doesn't suit here. But,
init(ReservationSchedulerConfiguration conf) has been implemented already?? :
well then you can remove configurable and also as per previous comment just
have the {{Configuration}} as the param.
# ??thought of passing the same to IterativePlanner.java &
TryManyReservationAgents.java as both classes has implemented ReservationAgent
interface, but there is no use of it currently?? : ok missed to see that they
are extending ReservationAgent, would just suggest to have no op methods in
{{PlanningAlgorithm}} and {{TryManyReservationAgents}}
> ReservationAgents are not correctly configured
> ----------------------------------------------
>
> Key: YARN-5703
> URL: https://issues.apache.org/jira/browse/YARN-5703
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler, resourcemanager
> Affects Versions: 3.0.0-alpha1
> Reporter: Sean Po
> Assignee: Manikandan R
> Attachments: YARN-5703.001.patch, YARN-5703.002.patch,
> YARN-5703.003.patch
>
>
> In AbstractReservationSystem, the method that instantiates a ReservationAgent
> does not properly initialize it with the appropriate configuration because it
> expects the ReservationAgent to implement Configurable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
