[
https://issues.apache.org/jira/browse/YARN-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868214#comment-15868214
]
Naganarasimha G R commented on YARN-5703:
-----------------------------------------
i think we are almost close to the final patch, few nits :
# smoothness factor has been converted to a configuration in
{{AlignedPlannerWithGreedy}}, which IMO should be ok.
# AlignedPlannerWithGreedy, ln no 58, seems like not required, pls remove it.
# PlanningAlgorithm, ln no 208, earlier a blank line was there and i feel it
should be there even now.
# ReservationAgent, ln no 73, just leave one blank line before the method.
Also could you take a look at the whitespace and checkstyle comments ?
Hope @sean po also takes a look at the patch to finalize the modifications !
> ReservationAgents are not correctly configured
> ----------------------------------------------
>
> Key: YARN-5703
> URL: https://issues.apache.org/jira/browse/YARN-5703
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler, resourcemanager
> Affects Versions: 3.0.0-alpha1
> Reporter: Sean Po
> Assignee: Manikandan R
> Attachments: YARN-5703.001.patch, YARN-5703.002.patch,
> YARN-5703.003.patch, YARN-5703.004.patch, YARN-5703.005.patch,
> YARN-5703.006.patch, YARN-5703.007.patch
>
>
> In AbstractReservationSystem, the method that instantiates a ReservationAgent
> does not properly initialize it with the appropriate configuration because it
> expects the ReservationAgent to implement Configurable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
