[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881523#comment-15881523
]
Sangjin Lee commented on YARN-6027:
-----------------------------------
In addition to [~varun_saxena]'s comments, I have a couple of comments.
(FlowActivityRowKey.java)
- In addition to Varun's comment above, in fact the new {{decode()}} method
seems largely redundant with {{FlowActivityRowKeyConverter.decode()}}. Is there
a reason not to simply use it? The same comment goes for
{{getRowKeyAsString()}}. Converters are how we apply encoding and decoding
consistently, and we should try to stick to that as much as possible.
(AbstractHBaseTestBase.java)
- I am a little curious about this refactoring. Is the idea to split the
current reader unit tests based on this abstract class? At least for now, only
{{TestTimelineReaderWebServicesHBaseStorage}} is using it.
- Is the name the best? Also, if this is specifically for reader unit tests, it
might be better to place it in the reader package and indicate that in the
class name also; e.g. {{AbstractTimelineReaderHBaseTestBase}}
> Support fromid(offset) filter for /flows API
> --------------------------------------------
>
> Key: YARN-6027
> URL: https://issues.apache.org/jira/browse/YARN-6027
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6027-YARN-5355.0001.patch,
> YARN-6027-YARN-5355.0002.patch, YARN-6027-YARN-5355.0003.patch,
> YARN-6027-YARN-5355.0004.patch
>
>
> In YARN-5585 , fromId is supported for retrieving entities. We need similar
> filter for flows/flowRun apps and flow run and flow as well.
> Along with supporting fromId, this JIRA should also discuss following points
> * Should we throw an exception for entities/entity retrieval if duplicates
> found?
> * TimelieEntity :
> ** Should equals method also check for idPrefix?
> ** Does idPrefix is part of identifiers?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
