[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887179#comment-15887179
]
Rohith Sharma K S commented on YARN-6027:
-----------------------------------------
bq. I am also not 100% sold on RowKey. Again, it is not really about them being
a row key type. Should we not introduce this interface (and even the converter
interface for that matter) for now until it becomes clear we need polymorphism
on this?
Agree, will remove this interface. One of the intention behind this to add is
method getRowKey() is present in all the key classes. Thought it will be good
to move as separate interface.
As a summary on interface, below are the consensus. Please add if I have
missed/misunderstood the consensus.
# Lets create a separate interface KeyConverterToString.
# Convertor classes can implement both KeyConvertor as well as
KeyConverterToString. {code}final private static class
FlowActivityRowKeyConverter implements
KeyConverter<FlowActivityRowKey>,
KeyConverterAsString<FlowActivityRowKey> {{code}
# Rowkey Interface need not required.
# Will create methods with explicit names by its purpose.
# Regarding using Separator.QUALIFIERS, let me check code for feasibility.
> Support fromid(offset) filter for /flows API
> --------------------------------------------
>
> Key: YARN-6027
> URL: https://issues.apache.org/jira/browse/YARN-6027
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6027-YARN-5355.0001.patch,
> YARN-6027-YARN-5355.0002.patch, YARN-6027-YARN-5355.0003.patch,
> YARN-6027-YARN-5355.0004.patch, YARN-6027-YARN-5355.0005.patch
>
>
> In YARN-5585 , fromId is supported for retrieving entities. We need similar
> filter for flows/flowRun apps and flow run and flow as well.
> Along with supporting fromId, this JIRA should also discuss following points
> * Should we throw an exception for entities/entity retrieval if duplicates
> found?
> * TimelieEntity :
> ** Should equals method also check for idPrefix?
> ** Does idPrefix is part of identifiers?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
