[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886146#comment-15886146
]
Rohith Sharma K S commented on YARN-6027:
-----------------------------------------
bq. RowKeyConverter interface's type parameter can extend RowKey. I guess it
makes sense only in this scenario.
RowKeyConvertor interface extended from KeyConvertor interface. RowKey is
interface which is implemented by HBase table row key class . Both
RowKeyConvertor and RowKey interfaces are different.
bq. In TestRowKeys, we should use new CLUSTER, flow name and user for
conversion which uses TimelineReaderUtils#DEFAULT_DELIMITER_CHAR instead of
Separator#QUALIFIER.
both are same right? any issues will happen because of enum? I debug the code,
the value is ! itself in cluster. May be need to add more combination of tests.
bq. TimelineReaderUtils should be final class.
Even I got doubt while removing final, why it should be final? utils class
should be public, but not final right?
bq. FROMID_KEY should be annotated with VisibleForTesting
IIUC, public static final constants need not to be annotated as
VisibleForTesting since these constants can be used by anyone.
bq. I was wondering if we should throw exception mentioning Invalid fromId is
specified from within decode(String) method?
make sense, lets create a message inside FlowActivityEntityReader
bq. Why not throw BadRequestException from newly added code in
FlowActivityEntityReader?
however, IllegaArgumentException is converted to BadRequestException in
TimelineReaderWebServices. May be BadRequestException can be thrown directly.
> Support fromid(offset) filter for /flows API
> --------------------------------------------
>
> Key: YARN-6027
> URL: https://issues.apache.org/jira/browse/YARN-6027
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6027-YARN-5355.0001.patch,
> YARN-6027-YARN-5355.0002.patch, YARN-6027-YARN-5355.0003.patch,
> YARN-6027-YARN-5355.0004.patch, YARN-6027-YARN-5355.0005.patch
>
>
> In YARN-5585 , fromId is supported for retrieving entities. We need similar
> filter for flows/flowRun apps and flow run and flow as well.
> Along with supporting fromId, this JIRA should also discuss following points
> * Should we throw an exception for entities/entity retrieval if duplicates
> found?
> * TimelieEntity :
> ** Should equals method also check for idPrefix?
> ** Does idPrefix is part of identifiers?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
